Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for text in links for #351

Closed
wants to merge 1 commit into from

Conversation

levimykel
Copy link
Contributor

Resolves: DT-2284

Description

It adds support for display text in links when using the asLinkAttrs helper function. Tests updated to match.

Note: I had to use an override to get it to work. This should be removed in the actual release process.

Checklist

  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

N/A

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@levimykel levimykel self-assigned this Aug 29, 2024
@levimykel levimykel closed this Aug 30, 2024
@levimykel
Copy link
Contributor Author

This was closed as the update is not required for this helper.

@levimykel levimykel deleted the lg/text-in-links-helpers branch August 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant